On Wed, Sep 07, 2022 at 06:02:24PM +0530, Viresh Kumar wrote: > Hi Anthony, > > Thanks a lot for the in-depth review, it is really helpful. > > I don't have much knowledge of the Xen code and wanted this code for I2C and > GPIO to be tested on Xen for the work we are doing around hypervisor agnostic > backends [1]. > > I started looking for a simple device's implementation and began by (blindly) > copying code from Keyboard device and so much of wasted code in here, which > isn't really required. > > On 06-09-22, 17:15, Anthony PERARD wrote: > > On Mon, Aug 22, 2022 at 02:45:13PM +0530, Viresh Kumar wrote: > > > An example of domain configuration for Virtio I2c: > > > i2c = [ "" ] > > > > Is this doing something meaningful (with the whole series applied)? > > If I am not wrong, this is required by parse_i2c_list()'s implementation. > Without this I don't get the I2C device populated in the guest.
Sorry, I should have added more context to may question. In my mind, I2C is just a communication protocol between a device and a CPU, like USB or PCI. So to me there is missing information about which device or kind of device to present to a guest in this example. For example, for PCI we give a path to the device (via bdf=), and for USB it can be a kind of device to emulate or select a device based on the path to it (bus, addr). Cheers, -- Anthony PERARD
