Hi Michal,
> -----Original Message-----
> From: Michal Orzel <[email protected]>
> > +- #address-cells and #size-cells
> > +
> > + Specify the number of cells used for the address and size of the
> > + "xen,static-heap" property. Note that according to the device tree
> > + specification, the number of address cells and size cells of
> > + "xen,static-heap" is determined by the parent #address-cells and
> > + #size-cells of the top-level "chosen" node.
> I am not sure we should put the information about #address-cells and #size-
> cells in that form.
> Firstly because /chosen node is always a child of / node and according to
> specs [1]
> the #address-cells and #size-cells are required properties for the root node.
>
> If we want to still mention it I would just write under xen,static-heap:
> "Number of address and size cells for the xen,static-heap property is
> determined
> by the root node #address-cells/#size-cells".
Thanks, I will address this comments and ...
>
> > + printk("Checking for static heap in /chosen\n");
> > + if ( address_cells < 1 || size_cells < 1 )
> > + {
> > + printk("fdt: node `%s': invalid #address-cells or
> > #size-cells\n",
> > + name);
> > + return -EINVAL;
> > + }
> This check is now the direct copy of the one in device_tree_get_meminfo so
> please remove it
> to avoid code duplication.
...this in v6, but I want to see if there would be more comments before sending
it.
Kind regards,
Henry
>
> ~Michal
>
> [1] https://devicetree-
> specification.readthedocs.io/en/v0.3/devicenodes.html
