> On 7 Sep 2022, at 09:55, Julien Grall <[email protected]> wrote: > > > > On 07/09/2022 09:53, Bertrand Marquis wrote: >>>> Otherwise if we start adding those kinds of checks, we will have to add >>>> them in at least 3 places in xen code. >>> >>> The solution I proposed above is easy to implement right now. My gut >>> feeling is tweaking __stringify (or else) will take a bit more time. >>> >>> If you (or Leo) can come up with a solution quickly then fine. Otherwise, I >>> think we still want some hardening for backporting purpose. >> I think a define in compile.h using stringify is the easiest solution: > > Ah! I thought you were suggesting to tweak __stringify. This is ...
Also possible but a bit more tricky >> #define XEN_STR_VERSION >> "__stringify(XEN_VERSION)"."__stringify(XEN_SUBVERSION)” Quotes at beginning and end should not be there. >> And then change the code in the following source code to use it: >> arch/arm/domain_build.c >> arch/arm/acpi/domain_build.c >> common/efi/boot.c > > ... much better. Thanks :-) Bertrand > > Cheers, > > -- > Julien Grall
