On 11.08.2022 18:37, Andrew Cooper wrote: > This reorders the fields in msi_info, but removes all the under-the-hood > parameter shuffling required to call pci_get_pdev(). > > No functional change. > > Signed-off-by: Andrew Cooper <[email protected]>
Oh, you've made the requested change yourself - thanks! Reviewed-by: Jan Beulich <[email protected]> While not the primary goal as per the description, I'm particularly happy to see ... > --- a/xen/xsm/flask/hooks.c > +++ b/xen/xsm/flask/hooks.c > @@ -918,7 +918,7 @@ static int flask_map_domain_msi ( > { > #ifdef CONFIG_HAS_PCI_MSI > const struct msi_info *msi = data; > - uint32_t machine_bdf = (msi->seg << 16) | (msi->bus << 8) | msi->devfn; > + uint32_t machine_bdf = msi->sbdf.sbdf; ... this open-coding go away. Jan
