On 11/08/2022 13:12, Jan Beulich wrote:
> Commit 68f5aac012b9 ("build: suppress future GNU ld warning about RWX
> load segments") didn't quite cover all the cases: Apparently I missed
> ones in the building of 32-bit helper objects because of only looking at
> incremental builds (where those wouldn't normally be re-built). Clone
> the workaround there to the specific Makefile in question.
>
> Reported-by: Andrew Cooper <[email protected]>
> Signed-off-by: Jan Beulich <[email protected]>

Acked-by: Andrew Cooper <[email protected]>

> ---
> Because of the use of LDFLAGS_DIRECT (coming directly from the Config.mk
> helpers in config/) having a central place to set this once isn't very
> easy: An option might be to introduce XEN_LDFLAGS_DIRECT and export that
> from where the other XEN_*FLAGS are also exported. The way it's done
> here is the less intrusive variant, though.

I think this is good enough for now.  This makefile is full of magic anyway.

Reply via email to