On 04/08/2022 16:04, Jane Malalane wrote:
> Clean up x86_64/kexec_reloc.S and x86_64/entry.S.
It would probably help to split the patch into two, because the reloc
changes are not related to the livepatchability fixes in entry.S
> This fixes the livepatching contents of entry.S.
Well - its the first of several bugfixes.
Specifically, we are adding ELF metadata so that the
livepatch-build-tools can actually binary diff changes in this area.
>
> RFC: I'm unsure on where the page_fault symbol should end, i.e. if
> unlike current code handle_exception_saved should be within page_fault
> like handle_exception is or not.
Jan: we've got two examples (page fault, and NMI) which don't form any
reasonable function layout. Both of these are fallthrough into
handle_{ist,}_exception.
I suggested labelling handle_{ist,}_exception as the main symbol, and
keeping {page_fault,nmi} as small stubs, because we want backtraces to
stay the same and not report {page_fault,nmi} for everything.
~Andrew
