Hi Xenia, > On 29 Jul 2022, at 07:31, Xenia Ragiadakou <[email protected]> wrote: > > Hi Jan, > > On 7/29/22 09:26, Jan Beulich wrote: >> On 28.07.2022 18:21, Xenia Ragiadakou wrote: >>> --- a/xen/arch/arm/domain.c >>> +++ b/xen/arch/arm/domain.c >>> @@ -63,7 +63,7 @@ static void do_idle(void) >>> rcu_idle_exit(cpu); >>> } >>> -void idle_loop(void) >>> +static void idle_loop(void) >> While you're adding "noreturn" below, shouldn't this one be marked so >> as well? Preferably with the addition: >> Reviewed-by: Jan Beulich <[email protected]> > > Yes, but I was not sure if this should go in this patch or in a separate one.
As you modify the function to make it static, I think it is ok to also add the noreturn in the same patch. With that done, you can add my: Reviewed-by: Bertrand Marquis <[email protected]> Cheers Bertrand > > -- > Xenia
