Hi Julien,
On 2022/7/16 1:03, Julien Grall wrote:
From: Julien Grall <[email protected]>
init_heap_pages() is using an open-code version of IS_ALIGNED(). Replace
it to improve the readability of the code.
No functional change intended.
Signed-off-by: Julien Grall <[email protected]>
---
Changes in v2:
- Patch added
---
xen/common/page_alloc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/xen/common/page_alloc.c b/xen/common/page_alloc.c
index fe0e15429af3..078c2990041d 100644
--- a/xen/common/page_alloc.c
+++ b/xen/common/page_alloc.c
@@ -1823,7 +1823,7 @@ static void init_heap_pages(
unsigned long s = mfn_x(page_to_mfn(pg + i));
unsigned long e = mfn_x(mfn_add(page_to_mfn(pg + nr_pages - 1),
1));
bool use_tail = (nid == phys_to_nid(pfn_to_paddr(e - 1))) &&
- !(s & ((1UL << MAX_ORDER) - 1)) &&
+ IS_ALIGNED(s, 1UL << MAX_ORDER) &&
(find_first_set_bit(e) <= find_first_set_bit(s));
unsigned long n;
LGTM.
Reviewed-by: Wei Chen <[email protected]>
