On 06.07.2022 17:32, Marek Marczykowski-Górecki wrote:
> +struct xue {
> + struct xue_dbc_reg *dbc_reg;
> + struct xue_dbc_ctx *dbc_ctx;
> + struct xue_erst_segment *dbc_erst;
> + struct xue_trb_ring dbc_ering;
> + struct xue_trb_ring dbc_oring;
> + struct xue_trb_ring dbc_iring;
> + struct xue_work_ring dbc_owork;
> + char *dbc_str;
> +
> + pci_sbdf_t sbdf;
> + uint64_t xhc_mmio_phys;
> + uint64_t xhc_mmio_size;
> + uint64_t xhc_dbc_offset;
One more observation: None of these four field look to be needed.
They're all used only in a single function, so could be local
variables there (and xhc_dbc_offset is only ever written, so
could be dropped altogether).
Jan
