Re: [XEN PATCH v3 01/25] tools/console: have one Makefile per program/directory

[Luca Fancellu]

> On 24 Jun 2022, at 17:03, Anthony PERARD <anthony.per...@citrix.com> wrote:
> 
> Sources of both xenconsoled and xenconsole are already separated into
> different directory and don't share anything in common. Having two
> different Makefile means it's easier to deal with *FLAGS.
> 
> Some common changes:
> Rename $(BIN) to $(TARGETS), this will be useful later.
> Stop removing *.so *.rpm *.a as they aren't created here.
> Use $(OBJS-y) to list objects.
> Update $(CFLAGS) for the directory rather than a single object.
> 
> daemon:
>    Remove the need for $(LDLIBS_xenconsoled), use $(LDLIBS) instead.
>    Remove the need for $(CONSOLE_CFLAGS-y) and use $(CFLAGS-y)
>       instead.
> 
> client:
>    Remove the unused $(LDLIBS_xenconsole)
> 
> Signed-off-by: Anthony PERARD <anthony.per...@citrix.com>

Hi Antony,

It looks good to me.

Reviewed-by: Luca Fancellu <luca.fance...@arm.com>