Hi Xenia, > On 5 Jul 2022, at 13:21, Xenia Ragiadakou <[email protected]> wrote: > > Add the function prototype of show_stack() in <asm/processor.h> header file > so that it is visible before its definition in traps.c. > > Although show_stack() is referenced only in traps.c, it is declared with > external linkage because, during development, it is often called also by > other files for debugging purposes. Declaring it static would increase > development effort. Add appropriate comment > > Signed-off-by: Xenia Ragiadakou <[email protected]>
Reviewed-by: Bertrand Marquis <[email protected]> Cheers Bertrand > --- > xen/arch/arm/include/asm/processor.h | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/xen/arch/arm/include/asm/processor.h > b/xen/arch/arm/include/asm/processor.h > index 4188ec6bfb..c021160412 100644 > --- a/xen/arch/arm/include/asm/processor.h > +++ b/xen/arch/arm/include/asm/processor.h > @@ -558,7 +558,9 @@ extern register_t __cpu_logical_map[]; > void panic_PAR(uint64_t par); > > void show_execution_state(const struct cpu_user_regs *regs); > +/* Debugging functions are declared with external linkage to aid > development. */ > void show_registers(const struct cpu_user_regs *regs); > +void show_stack(const struct cpu_user_regs *regs); > //#define dump_execution_state() > run_in_exception_handler(show_execution_state) > #define dump_execution_state() WARN() > > -- > 2.34.1 >
