On 21/06/2022 08:23, Juergen Gross wrote:
> diff --git a/e820.c b/e820.c
> index ad91e00b..49b16878 100644
> --- a/e820.c
> +++ b/e820.c
> @@ -29,6 +29,38 @@
>  #include <mini-os/e820.h>
>  #include <xen/memory.h>
>  
> +static unsigned long e820_initial_reserved_pfns;
> +
> +unsigned long e820_get_current_pages(void)
> +{
> +    domid_t domid = DOMID_SELF;
> +    long ret;
> +
> +    ret = HYPERVISOR_memory_op(XENMEM_current_reservation, &domid);
> +    if ( ret < 0 )
> +    {
> +        xprintk("could not get memory size\n");

%ld ret

Also, xprintk() vs ...

> +        do_exit();
> +    }
> +
> +    return ret - e820_initial_reserved_pfns;
> +}
> +
> +unsigned long e820_get_max_pages(void)
> +{
> +    domid_t domid = DOMID_SELF;
> +    long ret;
> +
> +    ret = HYPERVISOR_memory_op(XENMEM_maximum_reservation, &domid);
> +    if ( ret < 0 )
> +    {
> +        printk("Could not get maximum pfn\n");

... printk()?

Shouldn't they both be printk()?  Can fix both issues on commit.

~Andrew

Reply via email to