> On 20 May 2022, at 13:09, Julien Grall <[email protected]> wrote: > > From: Julien Grall <[email protected]> > > Currently, the function xen_pt_update() will flush the TLBs even when > the mappings are inserted. This is a bit wasteful because we don't > allow mapping replacement. Even if we were, the flush would need to > happen earlier because mapping replacement should use Break-Before-Make > when updating the entry. > > A single call to xen_pt_update() can perform a single action. IOW, it > is not possible to, for instance, mix inserting and removing mappings. > Therefore, we can use `flags` to determine what action is performed. > > This change will be particularly help to limit the impact of switching > boot time mapping to use xen_pt_update(). > > Signed-off-by: Julien Grall <[email protected]>
Hi Julien, It looks ok to me. I’ve also tested it starting, console-ing, destroying few guests and I’ve got no problem Reviewed-by: Luca Fancellu <[email protected]> Tested-by: Luca Fancellu <[email protected]>
