On 24.05.2022 04:13, Lin Liu （刘林） wrote:
> On 23.05.2022 11:52, Lin Liu wrote:
>>> --- a/tools/libs/guest/xg_dom_decompress_unsafe_xz.c
>>> +++ b/tools/libs/guest/xg_dom_decompress_unsafe_xz.c
>>> @@ -34,6 +34,11 @@ static inline u32 le32_to_cpup(const u32 *p)
>>> return cpu_to_le32(*p);
>>> }
>>>
>>> +static inline u32 le32_to_cpu(u32 val)
>>> +{
>>> + return le32_to_cpup((const u32 *)&val);
>>> +}
>>
>> Why the cast? And why not uint32_t?
>>
>> Jan
>
> le32_to_cpup has following prototye and definition
>
> static inline u32 le32_to_cpup(const u32 *p)
> {
> return cpu_to_le32(*p);
> }
>
> xg_dom_decompress_unsafe_xz.c redefine and use u32, use u32 to keep consistent
> typedef uint32_t u32;
This answers neither part of my question. For u32 vs uint32_t, please
also see ./CODING_STYLE.
Jan
