On 23/05/2022 15:56, Julien Grall wrote: > Hi, > > On 23/05/2022 15:50, Lin Liu wrote: >> Update to use byteswap to swap bytes >> be*_to_cpup(p) is short for be*to_cpu(*p), update to use latter >> one explictly > > But why?
Because deleting code obfuscation constructs *is* the point of the cleanup. > I really don't have a suggestion on the comment because I disagree > (and AFAICT Jan as well) with the approach. Dropping the obfuscation has uncovered pre-existing bugs in the hypervisor. The series stands on its own merit. While I can't help if you like it or not, it really does bring an improvement to code quality and legibility. If you have no technical objections, and no suggestions for how to do it differently while retaining the quality and legibility improvements, then "I don't like it" doesn't block it going in. I specifically do like this change, because it does improve the codebase. ~Andrew
