On 11.05.2022 03:46, Wei Chen wrote: > In previous code, Xen was using KERN_WARNING for log message > when Xen found a node without memory. Xen will print this > warning message, and said that this may be an BIOS Bug or > mis-configured hardware. But actually, this warning is bogus, > because in an NUMA setting, nodes can only have processors, > and with 0 bytes memory. So it is unreasonable to warn about > BIOS or hardware corruption based on the detection of node > with 0 bytes memory. > > So in this patch, we remove the warning messages, but just > keep an info message to info users that there is one or more > nodes with 0 bytes memory in the system. > > Signed-off-by: Wei Chen <[email protected]>
Reviewed-by: Jan Beulich <[email protected]> preferably with ... > --- a/xen/arch/x86/srat.c > +++ b/xen/arch/x86/srat.c > @@ -549,8 +549,7 @@ int __init acpi_scan_nodes(paddr_t start, paddr_t end) > uint64_t size = nodes[i].end - nodes[i].start; > > if ( size == 0 ) > - printk(KERN_WARNING "SRAT: Node %u has no memory. " > - "BIOS Bug or mis-configured hardware?\n", i); > + printk(KERN_INFO "SRAT: Node %u has no memory.\n", i); ... the full stop also dropped (and maybe the upper-case N converted to lower-case). Jan
