On 5/3/22 05:43, Luca Fancellu wrote: > > >> On 2 May 2022, at 14:53, Daniel P. Smith <[email protected]> >> wrote: >> >> On 5/2/22 09:49, Daniel P. Smith wrote: >>> On 5/2/22 09:42, Jason Andryuk wrote: >>>> On Mon, May 2, 2022 at 9:31 AM Daniel P. Smith >>>> <[email protected]> wrote: >>>>> diff --git a/xen/arch/arm/setup.c b/xen/arch/arm/setup.c >>>>> index d5d0792ed4..b9057222d6 100644 >>>>> --- a/xen/arch/arm/setup.c >>>>> +++ b/xen/arch/arm/setup.c >>>>> @@ -1048,6 +1048,10 @@ void __init start_xen(unsigned long >>>>> boot_phys_offset, >>>>> /* Hide UART from DOM0 if we're using it */ >>>>> serial_endboot(); >>>>> >>>>> + if ( (rc = xsm_set_system_active()) != 0 ) >>>>> + panic("xsm(err=%d): " >>>>> + "unable to set hypervisor to SYSTEM_ACTIVE privilege\n", >>>>> err); >>>> >>>> You want to print rc in this message. >>> >>> Thanks, but now I want to figure out how that compile >> >> Ah, arm which I do not have a build env to do build tests. > > I’ve built this patch on arm (changing err to rc), everything looks fine, so > with that > addressed: > > Reviewed-by: Luca Fancellu <[email protected]>
Thank you and my apologies for not adding your review-by this morning. I had v6 queued to go out last night and missed this email before releasing.
