On 29.04.2022 17:49, Roger Pau Monné wrote: > On Fri, Apr 29, 2022 at 12:59:58PM +0200, Jan Beulich wrote: >> On 27.04.2022 12:47, Roger Pau Monne wrote: >>> @@ -3138,6 +3140,9 @@ void vmentry_virt_spec_ctrl(void) >>> >>> if ( cpu_has_virt_ssbd ) >>> wrmsr(MSR_VIRT_SPEC_CTRL, current->arch.msrs->virt_spec_ctrl.raw, >>> 0); >>> + else >>> + amd_set_legacy_ssbd(current->arch.msrs->virt_spec_ctrl.raw & >>> + SPEC_CTRL_SSBD); >> >> Would seem cheaper to use !val here (and then val for symmetry in >> the other function). > > I could even use !opt_ssbd, and that would be more similar to what's > done in vmexit_virt_spec_ctrl?
Might be an option, yet when using "val" there as well I don't see benefit similarity-wise. Using a local variable would imo still be cheaper than accessing a global one. But that's a matter of taste to a fair degree, so I'll leave it to you - all I'd really prefer to have is the functions using as similar / symmetric as possible conditions. Jan
