On 14.04.2022 13:47, Andrew Cooper wrote: > There are no .S intermediate files, so rework in terms of head-bin-objs. > > No functional change. > > Signed-off-by: Andrew Cooper <[email protected]> > --- > CC: Jan Beulich <[email protected]> > CC: Roger Pau Monné <[email protected]> > CC: Wei Liu <[email protected]> > CC: Anthony PERARD <[email protected]> > > I'm slightly -1 on this, because > > head-bin-objs := $(addprefix $(obj)/,$(head-bin-objs)) > > is substantial obfuscation which I'd prefer to bin.
Would ... > --- a/xen/arch/x86/boot/Makefile > +++ b/xen/arch/x86/boot/Makefile > @@ -1,16 +1,17 @@ > obj-bin-y += head.o > -head-srcs := cmdline.S reloc.S > > -nocov-y += $(head-srcs:.S=.o) > -noubsan-y += $(head-srcs:.S=.o) > -targets += $(head-srcs:.S=.o) > +head-bin-objs := cmdline.o reloc.o head-bin-objs := $(obj)/cmdline.o $(obj)/reloc.o > -head-srcs := $(addprefix $(obj)/, $(head-srcs)) > +nocov-y += $(head-bin-objs) > +noubsan-y += $(head-bin-objs) > +targets += $(head-bin-objs) nocov-y += $(notdir $(head-bin-objs)) etc perhaps be a little less obfuscation? Jan
