On 04/04/2022 13:45, Jan Beulich wrote: > On 04.04.2022 12:40, Roger Pau Monne wrote: >> Prevent the assembler from creating a .note.gnu.property section on >> the output objects, as it's not useful for firmware related binaries, >> and breaks the resulting rombios image. >> >> This requires modifying the cc-option Makefile macro so it can test >> assembler options (by replacing the usage of the -S flag with -c) and >> also stripping the -Wa, prefix if present when checking for the test >> output. > I notice you've ack-ed and committed this patch, which I'm happy to > see. However, I don't understand why you gave your ack here, when you > did refused to ack (and to explain yourself!) for "x86emul: fix test > harness build for gas 2.36". Why is this note section useful there > but not similarly useful here (or, the other way around, useless)?
TBH, I'd forgotten that patch. This work of Roger's came from a real XenServer regression which causes RomBIOS to explode. It needs backporting. In the longterm, I would like to see us use real linker scripts for the artefacts which have custom link requirements, because this is still a bodge. ~Andrew
