On Fri, Apr 01, 2022 at 03:04:44PM +0000, Andrew Cooper wrote: > On 01/04/2022 15:50, Anthony PERARD wrote: > > On Fri, Apr 01, 2022 at 04:37:18PM +0200, Roger Pau Monne wrote: > >> +EMBEDDED_EXTRA_CFLAGS += -fcf-protection=none > >> + > > I think making modification to $(EMBEDDED_EXTRA_CFLAGS) outside of > > "Config.mk" is confusing and would be better be avoided. > > EMBEDDED_EXTRA_CFLAGS in the root Config.mk is conceptually broken and > needs deleting.
I'm asking to remove "-fcf-protection=none" from the broken variable EMBEDDED_EXTRA_CFLAGS, and instead only modify the CFLAGS variable of "tools/firmware/". As this patch show, making modification to EMBEDDED_EXTRA_CFLAGS outside of Config.mk doesn't work because changes doesn't propagate. So the modification I've ask for the patch goes toward deleting EMBEDDED_EXTRA_CFLAGS, like you want. Cheers, -- Anthony PERARD
