On 18/03/2022 07:36, Hongda Deng wrote:
Hi Julien,
Hi Hongda,
-----Original Message----- From: Xen-devel <[email protected]> On Behalf Of Julien Grall Sent: 2022年2月21日 18:22 To: [email protected] Cc: [email protected]; Julien Grall <[email protected]>; Stefano Stabellini <[email protected]>; Bertrand Marquis <[email protected]>; Volodymyr Babchuk <[email protected]>; Julien Grall <[email protected]> Subject: [PATCH v3 08/19] xen/arm: mm: Re-implement early_fdt_map() using map_pages_to_xen() From: Julien Grall <[email protected]> Now that map_pages_to_xen() has been extended to support 2MB mappings, we can replace the create_mappings() calls by map_pages_to_xen() calls. The mapping can also be marked read-only has Xen as no business toIn my opinion I think it may should be: ... read-only as Xen has no business ... instead of: ... read-only has Xen as no business ...
You are right, I have updated the commit message.
For this and other patches before this: Reviewed-by: Hongda Deng <[email protected]>
There is one bug in patch #5 (I sent an e-mail with the possible fix). Can you confirm you are still happy with me to keep your reviewed-by for that patch?
For the other patches, I have already committed patch #1-#3. So I will add your tag on patches #4, #6, #7, #8.
Thank you for the review! Cheers, -- Julien Grall
