On 04.03.2022 18:46, Marco Solieri wrote: > --- a/xen/include/xen/mm.h > +++ b/xen/include/xen/mm.h > @@ -488,6 +488,8 @@ page_list_splice(struct page_list_head *list, struct > page_list_head *head) > list_for_each_entry_safe(pos, tmp, head, list) > # define page_list_for_each_safe_reverse(pos, tmp, head) \ > list_for_each_entry_safe_reverse(pos, tmp, head, list) > +# define page_list_for_each_reverse(pos, head) \ > + list_for_each_entry_reverse(pos, head, list) > #endif
There are two sets of macros (for there being two flavors of lists), and hence - even if you need only one form on Arm - the other form should be introduced right away. I also think it would be far better to merge this into the patch actually first needing the new construct, as only then it'll be able to judge whether none of the existing constructs would be a reasonable fit. Jan
