On Fri, Feb 18, 2022 at 05:29:42PM +0000, Jane Malalane wrote: > Add XEN_SYSCTL_PHYSCAP_ARCH_ASSISTED_xapic and > XEN_SYSCTL_PHYSCAP_ARCH_ASSISTED_x2apic to report accelerated xapic > and x2apic, on x86 hardware. > No such features are currently implemented on AMD hardware. > > For that purpose, also add an arch-specific "capabilities" parameter > to struct xen_sysctl_physinfo. > > Suggested-by: Andrew Cooper <[email protected]> > Signed-off-by: Jane Malalane <[email protected]> > --- > diff --git a/tools/include/libxl.h b/tools/include/libxl.h > index 51a9b6cfac..333ffad38d 100644 > --- a/tools/include/libxl.h > +++ b/tools/include/libxl.h > @@ -528,6 +528,13 @@ > #define LIBXL_HAVE_MAX_GRANT_VERSION 1 > > /* > + * LIBXL_HAVE_PHYSINFO_ASSISTED_APIC indicates that libxl_physinfo has > + * cap_assisted_x{2}apic fields, which indicates the availability of x{2}APIC
I think I'd rather have both cap_assisted_xapic and cap_assisted_x2apic spelled out in the comment as that would allow to grep for both string. > + * hardware assisted virtualization. > + */ > +#define LIBXL_HAVE_PHYSINFO_ASSISTED_APIC 1 Otherwise, tools/ side looks good. Thanks, -- Anthony PERARD
