On 07.02.2022 12:58, Roger Pau Monné wrote:
> On Mon, Feb 07, 2022 at 09:57:55AM +0100, Jan Beulich wrote:
>> On 06.02.2022 20:28, Julien Grall wrote:
>>> @@ -311,6 +312,7 @@ struct xenpf_firmware_info {
>>>
>>> /* Int16, Fn02: Get keyboard shift flags. */
>>> uint8_t kbd_shift_flags; /* XEN_FW_KBD_SHIFT_FLAGS */
>>> + struct dom0_vga_console_info vga;
>>
>> ... the structure name including "vga" (but if the #define is adjusted,
>> the field name would want to become "video" as well).
>
> It's my understanding that this will forcefully be
> XEN_VGATYPE_EFI_LFB, at which point we could consider giving a type
> name to the vesa_lfb field of dom0_vga_console_info (video_lfb) and
> use the same struct here?
>
> There's no need to propagate XEN_VGATYPE_TEXT_MODE_3 into this
> interface.
Hmm, yes, this is probably better / more clean. Julien, thoughts?
Jan
