On Wed, Jan 19, 2022 at 08:46:09AM +0100, Jan Beulich wrote: > On 18.01.2022 17:21, Anthony PERARD wrote: > > The added "source/" depends on whether we do out-of-tree build or not. > > Well, I guess we're free to add a "source => ." symlink even in the > in-tree build case, deviating slightly from what Linux does? That > would then slightly simplify your construct.
I'm not sure about that, but I can see only one issue with that: if one was to use "source/" in a make rules (in target or prerequisite), make would potentially have two different path leading to the same file when running out-of-tree. But that shouldn't happen has we have "$(srctree)". Currently, Kbuild doesn't remove "source" on distclean, but I guess we can do that, which would avoid the potential issue. I don't see other reason a link "source -> ." would be an issue, so I'll add that to the patch "build: adding out-of-tree support to the xen build". Thanks, -- Anthony PERARD
