On 18.01.2022 11:50, Anthony PERARD wrote: > On Tue, Dec 21, 2021 at 02:33:18PM +0100, Jan Beulich wrote: >> On 25.11.2021 14:39, Anthony PERARD wrote: >>> --- a/xen/Makefile >>> +++ b/xen/Makefile >>> @@ -171,6 +171,10 @@ export LEX = $(if $(FLEX),$(FLEX),flex) >>> # Default file for 'make defconfig'. >>> export KBUILD_DEFCONFIG := $(ARCH)_defconfig >>> >>> +# Copy CFLAGS generated by "Config.mk" so they can be reused later without >>> +# reparsing Config.mk by e.g. arch/x86/boot/. >>> +export XEN_COMMON_CFLAGS := $(CFLAGS) >> >> For my own understanding (it's hard to check being half way through the >> series): At this point there are no further adjustments expected to >> CFLAGS? > > I'm not sure what you mean. The comment should be explicit. > > CFLAGS is going to be adjusted after the copy, for the benefit of all > the 64bit code (when building x86_64). The "renamed" to XEN_CFLAGS to be > useable by the rest of the tree.
I guess I misread the comment, sorry. > The name "XEN_COMMON_CFLAGS" might not be the right one, it is only > common to everything in xen.git, so same flags that the toolstack would > work with. XEN_GLOBAL_CFLAGS would come to mind, but is unlikely to be viewed as significantly better. Maybe XEN_TREEWIDE_CFLAGS? Jan
