On 13.01.2022 14:50, Andrew Cooper wrote: > This is a fastpath on virtual vmentry/exit, and forcing guest_pat to be > spilled to the stack is bad. Performing the shift in a register is far more > efficient. > > Drop the (IMO useless) log message. MSR_PAT only gets altered on boot, and a > bad value will be entirely evident in the ensuing #GP backtrace. > > Signed-off-by: Andrew Cooper <[email protected]>
Reviewed-by: Jan Beulich <[email protected]> I'm curious though why ... > @@ -313,10 +313,9 @@ int hvm_set_guest_pat(struct vcpu *v, u64 guest_pat) > case PAT_TYPE_WRCOMB: > case PAT_TYPE_WRPROT: > case PAT_TYPE_WRTHROUGH: > - break; > + continue; ... you're going from "break" to "continue" here. Jan
