On Mon, Dec 06, 2021 at 03:34:18PM +0100, Jan Beulich wrote:
> On 29.11.2021 16:33, Roger Pau Monne wrote:
> > --- a/tools/tests/cpu-policy/test-cpu-policy.c
> > +++ b/tools/tests/cpu-policy/test-cpu-policy.c
> > @@ -386,16 +386,6 @@ static void test_msr_deserialise_failure(void)
> > .msr = { .idx = 0xce, .flags = 1 },
> > .rc = -EINVAL,
> > },
> > - {
> > - .name = "truncated val",
> > - .msr = { .idx = 0xce, .val = ~0ull },
> > - .rc = -EOVERFLOW,
> > - },
> > - {
> > - .name = "truncated val",
> > - .msr = { .idx = 0x10a, .val = ~0ull },
> > - .rc = -EOVERFLOW,
> > - },
> > };
>
> Why is this removal necessary? I don't think any of the additions further
> down actually replaces these.
There are no longer overflow errors, since the field in msr_policy for
both MSRs is now 64bits after this change. I've tried to explain this
in the commit message:
"Note this requires making the raw fields uint64_t so that it can
accommodate the maximum size of MSRs values, and in turn removing the
truncation tests."
Thanks, Roger.
