On Fri, Dec 18, 2020 at 01:37:44PM -0800, Elliott Mitchell wrote:
> Anything *_is_empty(), *_is_default(), or *_gen_json() is going to be
> examining the pointed to thing, not modifying it. This potentially
> results in higher-performance output. This also allows spreading
> constants further, allowing more checking and security.
>
> Signed-off-by: Elliott Mitchell <[email protected]>
This patch doesn't build.
libxl_cpuid.c:510:17: error: conflicting types for
‘libxl_cpuid_policy_list_gen_json’
510 | yajl_gen_status libxl_cpuid_policy_list_gen_json(yajl_gen hand,
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
In file included from libxl_internal.h:89,
from libxl_cpuid.c:15:
/home/sheep/work/xen/tools/libs/light/../../../tools/include/libxl_json.h:30:17:
note: previous declaration of ‘libxl_cpuid_policy_list_gen_json’ was here
30 | yajl_gen_status libxl_cpuid_policy_list_gen_json(yajl_gen hand,
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
Also we talked about this patch before, in
https://lore.kernel.org/xen-devel/YImXfc4oaPgWzkeT@perard/
Cheers,
--
Anthony PERARD
