On Thu, Dec 16, 2021 at 12:36:41PM +0000, Andrew Cooper wrote: > On 06/12/2021 17:01, Anthony PERARD wrote: > > @@ -35,21 +29,13 @@ flask-set-bool: set-bool.o > > > > .PHONY: clean > > clean: > > - rm -f *.o *.opic *.so > > + rm -f *.o > > rm -f $(CLIENTS) > > $(RM) $(DEPS_RM) > > Here and in plenty of subsequent patches, there's manipulation of raw > `rm -f`'s which ought to be cleaned up to $(RM)
About using $(RM) or `rm -f`, I don't think we need to care if one or the other is used in Makefiles, they needs to be equivalent or things are going to fails. GNU make manual says that `rm` should exist, especially when things like autoconf are used. For example our ./configure scrips is using `rm -f` and I don't think we can configure that. So having RM configurable doesn't really serve any purpose. Beyond that, using $(RM) is good in order to be consistent, and changing "rm -f" to "$(RM)" is fine, I might not doing it myself or ask for it. > I can fix this on commit if you're happy. For the avoidance of doubt, yes, I'm happy with the patch that have been committed. Thanks, -- Anthony PERARD
