On 25.11.2021 14:39, Anthony PERARD wrote: > $(srctree) is a better description for the source directory than > $(BASEDIR) that has been used for both source and build directory > (which where the same). > > This adds $(srctree) to a few path where make's VPATH=$(srctree) won't > apply. And replace $(BASEDIR) by $(srctree). > > Introduce "$(srcdir)" as a shortcut for "$(srctree)/$(src)" as the > later is used often enough. > > Signed-off-by: Anthony PERARD <[email protected]>
Acked-by: Jan Beulich <[email protected]> One remark: > --- a/xen/scripts/Makefile.clean > +++ b/xen/scripts/Makefile.clean > @@ -5,9 +5,12 @@ > > src := $(obj) > > +# shortcut for $(srctree)/$(src) > +srcdir := $(srctree)/$(src) Might it make sense to generalize the comment to "# shortcuts" right away, in case further ones appear? There seems little reason to have the comment duplicate what the assignment actually does. Jan
