On 15.12.2021 23:21, Andrew Cooper wrote: > dom0-cpuid= is going to want to reuse the common parsing loop, so factor it > out into parse_cpuid(). > > Irritatingly, despite being static const, the features[] array gets duplicated > each time parse_cpuid() is inlined. As it is a large (and ever growing with > new CPU features) datastructure, move it to being file scope so all inlines > use the same single object. > > No functional change. > > Signed-off-by: Andrew Cooper <[email protected]>
Reviewed-by: Jan Beulich <[email protected]> > We probably want to be wary of fallout from this pattern elsewhere. I only > noticed it by chance. While that sounds at least close to a bug, there might by some subtle reason for why they have to do it that way. Jan
