On Thu, Dec 16, 2021 at 09:20:14AM +0000, Andrew Cooper wrote:
> There are two problems, both in the all_sources definition.
>
> First, everything in arch/*/include gets double hits with cscope queries,
> because they end up getting listed twice in cscope.files.
>
> Drop the first `find` rune of the three, because it's redundant with the third
> rune following c/s 725381a5eab3 ("xen: move include/asm-* to
> arch/*/include/asm").
>
> Second, and this way for a long time:
>
> $ make cscope
> ( find arch/x86/include -name '*.h' -print; find include -name '*.h' -print;
> find xsm arch/x86 common drivers lib test -name '*.[chS]' -print ) >
> cscope.files
> cscope -k -b -q
> cscope: cannot find file arch/x86/efi/efi.h
> cscope: cannot find file arch/x86/efi/ebmalloc.c
> cscope: cannot find file arch/x86/efi/compat.c
> cscope: cannot find file arch/x86/efi/pe.c
> cscope: cannot find file arch/x86/efi/boot.c
> cscope: cannot find file arch/x86/efi/runtime.c
It's kind of weird that cscope can't read symlinks, but I guess that the
way it is.
> This is caused by these being symlinks to common/efi. Restrict all find runes
> to `-type f` to skip symlinks, because common/efi/*.c are already listed.
>
> Signed-off-by: Andrew Cooper <[email protected]>
Reviewed-by: Anthony PERARD <[email protected]>
> Anthony: I looked through the remainder of your build series and I cant spot
> any edits to all_sources. Apologies if I missed it.
I don't think I've made further edit of this.
Thanks,
--
Anthony PERARD
