On 03.12.2021 17:10, Luca Fancellu wrote: >> On 3 Dec 2021, at 10:56, Jan Beulich <[email protected]> wrote: >> >> When it was introduced, it was imo placed way too high up, making it >> necessary to forward-declare way too many static functions. Move it down >> together with >> - the efi_check_dt_boot() stub, which afaict was deliberately placed >> immediately ahead of the #include, >> - blexit(), because of its use of the efi_arch_blexit() hook. >> Move up get_value() and set_color() to before the inclusion so their >> forward declarations can also be zapped. >> > > With the “const” attribute now some function in this serie are above the char > line > limit, however everything looks fine.
I wonder which part of this patch you're referring to. I don't recall any addition of const here - I think I'm strictly only moving code around some code and delete some declarations. I've further checked the code being moved, and I couldn't spot any line going beyond 80 chars. > Reviewed-by: Luca Fancellu <[email protected]> Thanks. Jan
