Hi Ayan, > On 30 Nov 2021, at 18:12, Ayan Kumar Halder <[email protected]> > wrote: > > GENMASK(30, 21) should be 0x7fe00000. Fixed this in the comment > in bitops.h. > > Signed-off-by: Ayan Kumar Halder <[email protected]> Reviewed-by: Bertrand Marquis <[email protected]>
Cheers Bertrand > --- > Changelog :- > v2 :- 1. Replaced the word "vector" with "value" in comment. > 2. Changed 0x07fe00000 to 0x7fe00000. > 3. Updated the commit message to make it meaningful. > (All suggested by Jan Beulich) > > xen/include/xen/bitops.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/xen/include/xen/bitops.h b/xen/include/xen/bitops.h > index a64595f68e..dad4b5aa1e 100644 > --- a/xen/include/xen/bitops.h > +++ b/xen/include/xen/bitops.h > @@ -5,7 +5,7 @@ > /* > * Create a contiguous bitmask starting at bit position @l and ending at > * position @h. For example > - * GENMASK(30, 21) gives us the 32bit vector 0x01fe00000. > + * GENMASK(30, 21) gives us the 32bit value 0x7fe00000. > */ > #define GENMASK(h, l) \ > (((~0UL) << (l)) & (~0UL >> (BITS_PER_LONG - 1 - (h)))) > -- > 2.17.1 >
