On 30.11.2021 23:01, Andrew Cooper wrote:
> The supported parameter was added in 2d9b91f1aeaa ("VMX/vPMU: fix DebugCtl MSR
> handling"), it laid the groundwork for XSA-269, and in the meantime
> 2a8a8e99feb9 ("x86/vtx: Fix the checking for unknown/invalid MSR_DEBUGCTL
> bits") totally rewrote MSR_DEBUGCTL handling.
>
> Strip out the parameter again.
>
> Signed-off-by: Andrew Cooper <[email protected]>
Reviewed-by: Jan Beulich <[email protected]>
albeit please with ...
> @@ -113,14 +111,13 @@ void vpmu_save(struct vcpu *v);
> int vpmu_load(struct vcpu *v, bool_t from_guest);
> void vpmu_dump(struct vcpu *v);
>
> -static inline int vpmu_do_wrmsr(unsigned int msr, uint64_t msr_content,
> - uint64_t supported)
> +static inline int vpmu_do_wrmsr(unsigned int msr, uint64_t msr_content)
> {
> - return vpmu_do_msr(msr, &msr_content, supported, 1);
> + return vpmu_do_msr(msr, &msr_content, 1);
... "true" and ...
> }
> static inline int vpmu_do_rdmsr(unsigned int msr, uint64_t *msr_content)
> {
> - return vpmu_do_msr(msr, msr_content, 0, 0);
> + return vpmu_do_msr(msr, msr_content, 0);
... "false" used respectively, as you're touching this anyway.
Jan
