On Wed, Oct 27, 2021 at 09:12:14AM +0000, Oleksandr Andrushchenko wrote: > Hi, Roger! > > On 13.10.21 14:11, Roger Pau Monné wrote: > > On Thu, Sep 30, 2021 at 10:52:13AM +0300, Oleksandr Andrushchenko wrote: > >> From: Oleksandr Andrushchenko <[email protected]> > >> > >> This is in preparation for dynamic assignment of the vpci register > >> handlers depending on the domain: hwdom or guest. > >> > >> Signed-off-by: Oleksandr Andrushchenko <[email protected]> > >> Reviewed-by: Michal Orzel <[email protected]> > >> --- > >> Since v1: > >> - constify struct pci_dev where possible > >> --- > >> xen/drivers/vpci/vpci.c | 7 ++++++- > >> xen/include/xen/vpci.h | 2 ++ > >> 2 files changed, 8 insertions(+), 1 deletion(-) > >> > >> diff --git a/xen/drivers/vpci/vpci.c b/xen/drivers/vpci/vpci.c > >> index cbd1bac7fc33..1666402d55b8 100644 > >> --- a/xen/drivers/vpci/vpci.c > >> +++ b/xen/drivers/vpci/vpci.c > >> @@ -35,7 +35,7 @@ extern vpci_register_init_t *const __start_vpci_array[]; > >> extern vpci_register_init_t *const __end_vpci_array[]; > >> #define NUM_VPCI_INIT (__end_vpci_array - __start_vpci_array) > >> > >> -void vpci_remove_device(struct pci_dev *pdev) > >> +void vpci_remove_device_registers(const struct pci_dev *pdev) > > Making this const is kind of misleading, as you end up modifying > > contents of the pdev, is just that vpci data is stored as a pointer > > inside the struct so you avoid the effects of the constification. > Ok, I will remove const
Jan prefers the const, so please leave it. Thanks, Roger.
