I wrote (27th September):
> Juergen Gross writes ("Re: [PATCH v3 0/3] disable building of pv-grub and
> qemu-trad per default"):
> > On 10.09.21 17:34, Ian Jackson wrote:
> > > Juergen Gross writes ("[PATCH v3 0/3] disable building of pv-grub and
> > > qemu-trad per default"):
> > >> This is a first step of deprecating pv-grub and qemu-trad including
> > >> ioemu-stubdom. Switch the default to not building it.
> > >
> > > This is now fully acked. But can we wait with committing it until we
> > > have a decision about whether to (a) have osstest explicitly enable
> > > the pv-grub and qemu-trad builds (b) have osstest stop testing these
> > > configurations ?
> >
> > Any decisions made?
>
> No-one seems to have had any opinions. I'll take ...
>
> > FWIW I'd be fine dropping pv-grub builds and tests in OSStets, but I'd
> > rather keep testing qemu-trad stubdom tests.
>
> ... that as a proposal :-). think that is probably the right tradeoff.
>
> I think that means that means we need osstest patches to edit
> make-flight and ts-xen-build which
>
> * Explictly enables stubdom qemu build
> * Drops the pv-grub tests
>
> and those need to go in first.
>
> With my RM hat on, I think those changes to osstest may need a release
> ack since they have missed the LPD, but I will grant such an ack.
>
> As for the patches themselves, I may get to that tomorrow, but
> contributions would be very welcome.
Evidently I didn't get to that "tomorrow". But while checking up on
this with git-log -G I found osstest commit:
8dee6e333622d830b7a9373989f63b526a85cd94
make-flight: Drop pvgrub (pvgrub1) tests
I think this means
[PATCH v3 2/3] stubdom: disable building pv-grub
from this series can go in immediately.
With my RM hat on: I think this reduces risk, overall. There is some
risk of immediately build breakage but the patch could be readily
reverted.
Accordingly, patch 2/3 disabling pv-grub is
Release-Acked-by: Ian Jackson <[email protected]>
It also has my tools ack so I will commit it in a moment.
I think 3/3 is waiting for the osstest patch. In principle with my RM
hat on I think these could go in but it would have to be very soon,
and the osstest change has to go in first.
Ian.
