On 24.08.2021 12:50, Anthony PERARD wrote: > Temporary fix the list of headers that cmdline.c and reloc.c depends > on, until the next time the list is out of sync again. > > Also, add the linker script to the list. > > Signed-off-by: Anthony PERARD <[email protected]>
Reviewed-by: Jan Beulich <[email protected]> Afaict this is independent of all earlier patches, so I'll make an attempt at committing this soon. > --- a/xen/arch/x86/boot/Makefile > +++ b/xen/arch/x86/boot/Makefile > @@ -2,19 +2,22 @@ obj-bin-y += head.o > > DEFS_H_DEPS = $(BASEDIR)/$(src)/defs.h $(BASEDIR)/include/xen/stdbool.h > > -CMDLINE_DEPS = $(DEFS_H_DEPS) $(BASEDIR)/$(src)/video.h > +CMDLINE_DEPS = $(DEFS_H_DEPS) $(BASEDIR)/$(src)/video.h \ > + $(BASEDIR)/include/xen/kconfig.h \ > + $(BASEDIR)/include/generated/autoconf.h Especially with this now needed in two places, I think down the road (unless we'll get dependency tracking automated here, which a part of your description suggests is not going to happen soon) we want kconfig.h := $(BASEDIR)/include/xen/kconfig.h \ $(BASEDIR)/include/generated/autoconf.h and then similarly ... > RELOC_DEPS = $(DEFS_H_DEPS) \ > $(BASEDIR)/include/generated/autoconf.h \ > $(BASEDIR)/include/xen/kconfig.h \ > $(BASEDIR)/include/xen/multiboot.h \ > $(BASEDIR)/include/xen/multiboot2.h \ > + $(BASEDIR)/include/xen/const.h \ multiboot.h := $(BASEDIR)/include/xen/multiboot.h \ $(BASEDIR)/include/xen/const.h \ (and by implication I think DEFS_H_DEPS would better be renamed to deps.h as well). Jan
