On 01.10.2021 09:11, Oleksandr Andrushchenko wrote: > On 01.10.21 03:34, Stefano Stabellini wrote: >> On Thu, 30 Sep 2021, Oleksandr Andrushchenko wrote: >>> From: Oleksandr Andrushchenko <[email protected]> >>> >>> While adding a PCI device mark it as such, so other frameworks >>> can distinguish it from DT devices. >>> For that introduce an architecture defined helper which may perform >>> additional initialization of the newly created PCI device. >>> >>> Signed-off-by: Oleksandr Andrushchenko <[email protected]> >> I get a build failure without CONFIG_PCI on ARM64: >> >> In file included from /local/repos/xen-upstream/xen/include/xen/pci.h:66:0, >> from /local/repos/xen-upstream/xen/include/xen/iommu.h:25, >> from /local/repos/xen-upstream/xen/include/xen/sched.h:12, >> from arch/arm/arm64/asm-offsets.c:9: >> /local/repos/xen-upstream/xen/include/asm/pci.h:127:46: error: ‘struct >> pci_dev’ declared inside parameter list will not be visible outside of this >> definition or declaration [-Werror] >> static inline void arch_pci_init_pdev(struct pci_dev *pdev) {} >> ^~~~~~~ >> cc1: all warnings being treated as errors > Ah, this then needs to be > struct pci_dev; > > static inline void arch_pci_init_pdev(struct pci_dev *pdev) {} > > Jan, as this is going to be Arm change, so can I keep your Ack please?
Of course you can, and me having said anyway "Applicable parts" makes me wonder why you ask. The ack clearly doesn't extend to Arm code; I can't give (valid) acks for code I'm not a maintainer of. This would be different for R-b, though. Jan
