On 28.09.2021 09:42, Durrant, Paul wrote:
> On 22/09/2021 15:38, Jan Beulich wrote:
>> Making these dependent upon "iommu=debug" isn't really helpful in the
>> field. Where touching respective code anyway also make use of %pp and
>> %pd.
>>
>> Requested-by: Andrew Cooper <[email protected]>
>> Signed-off-by: Jan Beulich <[email protected]>
>
> Reviewed-by: Paul Durrant <[email protected]>
Thanks.
>> @@ -515,14 +513,13 @@ static u16 __init parse_ivhd_device_rang
>> dev_length = sizeof(*range);
>> if ( header_length < (block_length + dev_length) )
>> {
>> - AMD_IOMMU_DEBUG("IVHD Error: Invalid Device_Entry Length!\n");
>> + AMD_IOMMU_ERROR("IVHD: invalid Device_Entry length\n");
>> return 0;
>> }
>>
>> if ( range->end.header.type != ACPI_IVRS_TYPE_END )
>> {
>> - AMD_IOMMU_DEBUG("IVHD Error: "
>> - "Invalid Range: End_Type %#x\n",
>> + AMD_IOMMU_ERROR("IVHD Error: invalid range: End_Type %#x\n",
>
> NIT: I guess you want to drop the 'Error' here like you did elsewhere.
Yes indeed. Fixed. Thanks for spotting.
Jan
