On 14.09.2021 18:43, Kevin Stefanov wrote:
> --- a/tools/libs/light/libxl_x86_acpi.c
> +++ b/tools/libs/light/libxl_x86_acpi.c
> @@ -20,6 +20,7 @@
>
> /* Number of pages holding ACPI tables */
> #define NUM_ACPI_PAGES 16
> +#define ALIGN(p, a) (((p) + ((a) - 1)) & ~((a) - 1))
Wouldn't this better live in xen-tools/libs.h?
> @@ -163,7 +159,6 @@ int libxl__dom_load_acpi(libxl__gc *gc,
> struct acpi_config config = {0};
> struct libxl_acpi_ctxt libxl_ctxt;
> int rc = 0, acpi_pages_num;
> - void *acpi_pages;
> unsigned long page_mask;
With, as pointed out by Andrew, this now dead variable also removed
Reviewed-by: Jan Beulich <[email protected]>
Jan
