On 24.08.2021 12:49, Anthony PERARD wrote: > This replace the use of a single .c file use for multiple .o file by > creating multiple .c file including the first one. > > There's quite a few issues with trying to build more than one object > file from a single source file: there's is a duplication of the make > rules to generate those targets; there is an additional ".file" symbol > added in order to differentiate between the object files; and the > tools/symbols have an heuristic to try to pick up the right ".file". > > This patch adds new .c source file which avoid the need to add a > second ".file" symbol and thus avoid the need to deal with those > issues. > > Also remove __OBJECT_FILE__ from $(CC) command line as it isn't used > anywhere anymore. And remove the macro "build-intermediate" since the > generic rules for single targets can be used. > > And rename the objects in mm/hap/ to remove the extra "level". > > Signed-off-by: Anthony PERARD <[email protected]> > Reviewed-by: Jan Beulich <[email protected]>
Hmm, when replying to 00/51 I didn't recall I gave an R-b for this one already. I'd like to restrict it some: It should be taken to stand for the technical correctness of the change. Nevertheless I'm not really happy with the introduction of the various tiny source files. I've meanwhile been wondering: Can't these be generated (in the build tree, as soon as that's possible to be separate) rather than getting put in the repo? Jan
