On 06.09.2021 15:35, Julien Grall wrote: > On 26/08/2021 11:12, Jan Beulich wrote: >> In all cases call the function just once instead of up to four times, at > > extra NIT: It is more like two because there is a else in > gnttab_release_mappings() :)
Well, I was viewing things from code gen pov, not so much execution paths. And of course "two" is not wrongly covered by "up to four" ;-) >> the same time avoiding to store a dangling pointer in a local variable. >> >> Signed-off-by: Jan Beulich <[email protected]> > > Reviewed-by: Julien Grall <[email protected]> Thanks. >> --- a/xen/common/grant_table.c >> +++ b/xen/common/grant_table.c > > [...] > > Everything below looks a duplicate. Might be an issue in your tools? Oops, indeed - some kind of glitch. Odd. Jan
