Hello, Juergen! On 03.09.21 13:26, Juergen Gross wrote: > On 03.09.21 10:33, Oleksandr Andrushchenko wrote: >> From: Oleksandr Andrushchenko <[email protected]> >> >> Arm's PCI passthrough implementation doesn't support legacy interrupts, >> but MSI/MSI-X. This can be the case for other platforms too. >> For that reason introduce a new CONFIG_PCI_SUPP_LEGACY_IRQ and add >> it to the CFLAGS and compile the relevant code in the toolstack only if >> applicable. >> >> Signed-off-by: Oleksandr Andrushchenko <[email protected]> >> Cc: Ian Jackson <[email protected]> >> Cc: Juergen Gross <[email protected]> >> --- >> tools/libs/light/Makefile | 4 ++++ >> tools/libs/light/libxl_pci.c | 13 +++++++++++++ >> 2 files changed, 17 insertions(+) >> >> diff --git a/tools/libs/light/Makefile b/tools/libs/light/Makefile >> index 7d8c51d49242..bd3f6be2a183 100644 >> --- a/tools/libs/light/Makefile >> +++ b/tools/libs/light/Makefile >> @@ -46,6 +46,10 @@ CFLAGS += -Wno-format-zero-length -Wmissing-declarations \ >> -Wno-declaration-after-statement -Wformat-nonliteral >> CFLAGS += -I. >> +ifeq ($(CONFIG_X86),y) >> +CFLAGS += -DCONFIG_PCI_SUPP_LEGACY_IRQ >> +endif >> + >> SRCS-$(CONFIG_X86) += libxl_cpuid.c >> SRCS-$(CONFIG_X86) += libxl_x86.c >> SRCS-$(CONFIG_X86) += libxl_psr.c >> diff --git a/tools/libs/light/libxl_pci.c b/tools/libs/light/libxl_pci.c >> index 59f3686fc85e..cd4fea46c3f7 100644 >> --- a/tools/libs/light/libxl_pci.c >> +++ b/tools/libs/light/libxl_pci.c >> @@ -1434,6 +1434,7 @@ static void pci_add_dm_done(libxl__egc *egc, >> } >> } >> fclose(f); >> +#ifndef CONFIG_PCI_SUPP_LEGACY_IRQ > > Why #ifndef? Shouldn't this be #ifdef (same below multiple times)?
Yes, you are right. I have to revert the logic, e.g. s/ifndef/ifdef Other than that, are you ok with CONFIG_PCI_SUPP_LEGACY_IRQ name? Thank you and sorry for the noise, Oleksandr > > > Juergen
