On 31.08.2021 14:31, Rahul Singh wrote: >> On 24 Aug 2021, at 4:53 pm, Jan Beulich <[email protected]> wrote: >> On 19.08.2021 14:02, Rahul Singh wrote: >>> --- /dev/null >>> +++ b/xen/drivers/passthrough/msi.c >>> @@ -0,0 +1,96 @@ >>> +/* >>> + * Copyright (C) 2008, Netronome Systems, Inc. >> >> While generally copying copyright statements when splitting source >> files is probably wanted (or even necessary) I doubt this is >> suitable here: None of the MSI code that you move was contributed >> by them afaict. > > Let me remove the "Copyright Copyright (C) 2008, Netronome Systems, Inc.” . > Can you please help me what copyright I will add for the next patch ?
None? If you look around, you will find that far from all source files have such a line (or multiple of them). >>> + * This program is free software; you can redistribute it and/or modify it >>> + * under the terms and conditions of the GNU General Public License, >>> + * version 2, as published by the Free Software Foundation. >>> + * >>> + * This program is distributed in the hope it will be useful, but WITHOUT >>> + * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or >>> + * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License >>> for >>> + * more details. >>> + * >>> + * You should have received a copy of the GNU General Public License along >>> with >>> + * this program; If not, see <http://www.gnu.org/licenses/>. >>> + */ >>> + >>> +#include <xen/init.h> >>> +#include <xen/pci.h> >>> +#include <asm/msi.h> >> >> You surely mean xen/msi.h here: Headers like this one should always >> be included by the producer, no matter that it builds fine without. >> Else you risk declarations and definitions to go out of sync. > Ok . Let me include here “xen/msi.h” and move other required includes to > “xen/msi.h" Why move stuff? xen/msi.h is fins to include asm/msi.h. It's just that including asm/msi.h here is not enough. Jan
