On 26.08.2021 15:24, Andrew Cooper wrote:
> On 26/08/2021 08:25, Jan Beulich wrote:
>> --- a/xen/drivers/passthrough/amd/iommu_map.c
>> +++ b/xen/drivers/passthrough/amd/iommu_map.c
>> @@ -467,6 +467,81 @@ int amd_iommu_reserve_domain_unity_unmap
>> return rc;
>> }
>>
>> +int amd_iommu_get_reserved_device_memory(iommu_grdm_t *func, void *ctxt)
>> +{
>> + unsigned int seg = 0 /* XXX */, bdf;
>
> Is this XXX intended to stay?
Yes - we've already got 3 similar instances plus at least two where the
hardcoding of segment 0 is not otherwise marked.
Jan
> I can't say I'm fussed about multi-segment handling, given the absence
> of support on any hardware I've ever encountered.
>
> ~Andrew
>
