Hi Julien, > -----Original Message----- > From: Julien Grall <[email protected]> > Sent: 2021年8月24日 1:54 > To: Wei Chen <[email protected]>; [email protected]; > [email protected]; [email protected] > Cc: Bertrand Marquis <[email protected]> > Subject: Re: [XEN RFC PATCH 09/40] xen/x86: Move numa_add_cpu_node to > common > > Hi Wei, > > On 11/08/2021 11:23, Wei Chen wrote: > > This function will be reused by Arm later, so we move it > > from arch/x86 to common. But we keep cpu_to_node and > > node_to_cpumask to x86 header file. Because cpu_to_node and > > node_to_cpumask have different implementation for x86 and Arm. > > We will move them to common header file when we change the Arm > > implementation in later patches. > > AFAICT, the Arm helpers are gated by !CONFIG_NUMA and the ones in common > code will be gated by CONFIG_NUMA. So I am not quite too understand why > they can't be moved now. Can you clarify it? >
Yes, you're right. After we had introduced !CONFIG_NUMA, we can move node_to_cpumask and cpu_to_node in this patch too. I will fix it in next version. > Cheers, > > -- > Julien Grall
