On 20.08.2021 09:44, Costin Lupu wrote: > On 8/20/21 9:52 AM, Jan Beulich wrote: >> On 19.08.2021 19:50, Costin Lupu wrote: >>> These changes introduce the page related definitions needed for mapping and >>> accessing guests memory. These values are intended to be used by any >>> toolstack >>> component that needs to map guests memory. Until now, the values were >>> defined >>> by the xenctrl.h header, therefore whenever a component had to use them it >>> also >>> had to add a dependency for the xenctrl library. >>> >>> This patch also introduces xen_mk_long() macrodefinition for defining long >>> constants both for C and assembler code. >> >> I'm still missing justification for the addition of a new header, especially >> as I don't see that header to gain much more contents down the road. >> > > For the first version, since it didn't need to include other headers, I > thought it would make sense to isolate the definitions in their own > headers. Now maybe it makes more sense to put the definitions in > arch-x86/xen.h, arch-arm.h and xen.h (the latter two) respectively. What > do you think? I'm open to suggestions here.
Well, yes, the headers you name are where I thought these new #define-s would go. Jan
